SRCH-6443: CodeDeploy hooks for crawler Resque (systemd alignment)#2002
Open
luisgmetzger wants to merge 1 commit intoGSA:stagingfrom
Open
SRCH-6443: CodeDeploy hooks for crawler Resque (systemd alignment)#2002luisgmetzger wants to merge 1 commit intoGSA:stagingfrom
luisgmetzger wants to merge 1 commit intoGSA:stagingfrom
Conversation
luisgmetzger
force-pushed
the
srch-6443-resque-crawler-fix
branch
from
2710b83 to
0bc168d
Compare
- Source optional /home/search/.config/searchgov-codedeploy.env (Ansible-managed on crawlers). - When REQUIRE_RESQUE_SERVICES=true: fail ApplicationStop if units missing; require active resque-worker/resque-scheduler in ValidateService. - After stop, terminate orphan resque processes (optional SKIP_ORPHAN_RESQUE_SIGTERM). - Add verify_resque_cwd.sh for REQUIRE_RESQUE_CWD_CHECK post-deploy validation.
luisgmetzger
force-pushed
the
srch-6443-resque-crawler-fix
branch
from
0bc168d to
25dff96
Compare
YaritzaGarcia
approved these changes
Apr 1, 2026
Collaborator
YaritzaGarcia
left a comment
YaritzaGarcia
left a comment
There was a problem hiding this comment.
I read everything and review it carefully and looks good to me.
selfdanielj
reviewed
Apr 1, 2026
| PUMA_SERVICE="${PUMA_SERVICE:-puma}" | ||
| RESQUE_WORKER_SERVICE="${RESQUE_WORKER_SERVICE:-resque-worker}" | ||
| RESQUE_SCHEDULER_SERVICE="${RESQUE_SCHEDULER_SERVICE:-resque-scheduler}" | ||
| APP_HEALTHCHECK_URL="${APP_HEALTHCHECK_URL:-http://127.0.0.1:3000/}" |
Contributor
There was a problem hiding this comment.
will the app even accept a http connection?
Contributor
|
this seems like a really complex solution to come up with that you probably can't have tested locally... what makes you think this will solve the problem? Were you able to do any local testing to show that this will work? Don't you have to add these scripts to appspec to run? As is, if this is merged, nothing will happen right? is this meant to run with capistrano, without capistrano, or be independent of capistrano? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRCH-6443
Production crawler Resque workers were not managed by systemd, so CodeDeploy
application_stop/application_startskippedresque-workerandresque-scheduler, leaving processes on pruned release paths.Changes
/home/search/.config/searchgov-codedeploy.env(installed by searchgov-ansible crawl playbook on crawlers) so hooks can enforce stricter checks only on those hosts.REQUIRE_RESQUE_SERVICES=true: fail ApplicationStop if units are missing; require active resque services in ValidateService.resqueprocesses (disable withSKIP_ORPHAN_RESQUE_SIGTERM=trueif needed).verify_resque_cwd.shinvoked whenREQUIRE_RESQUE_CWD_CHECK=true.Rollout
resque_systemdrole) on production crawlers.Related
LoadErrorin resque.log (companion PR).