feat: follow terminal cwd and download directories - #71
Open
htazq wants to merge 1 commit into
Open
Conversation
Owner
|
@sunxiaobin89 Can you help to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROMPT_COMMANDhook that emits standard OSC 7 working-directory reports without parsing visible promptsWhy these issues are together
#69 and #70 meet at the integrated SSH file-browser boundary and share the same path/session isolation work. I did not bundle other open issues:
pty-terminal.tsxplus its activation testsApp.tsx/locales, but fixes the unrelated connection-folder menu flowRto reconnect from a disconnected terminal #12 already have separate PRsBehavior covered
cdwith absolute and relative paths,cd ..,cd ~,cd -,pushd, andpopd%,#, and?cdValidation
pnpm test— 39 files, 525 tests passedpnpm build— passedpnpm i18n:check— 950 keys in both localescargo test --lib --lockedin Linux/Tauri container — 108 passed, 6 ignoredcargo check --lockedin Linux/Tauri container — passedcargo clippy --locked— completed; only existing repository warningsgit diff --check— passedRepository-wide
pnpm lintremains red on the same 3 pre-existing errors inconnection-dialog.tsxandsettings-modal.tsx. Repository-widecargo fmt --checkalso remains red on pre-existing formatting outside these hunks; both CI jobs are existing baseline conditions (Rust formatting is continue-on-error).Known boundaries
sudo -iorsu -starts a fresh login shell that discardsPROMPT_COMMAND, following resumes only when that shell itself emits OSC 7 or after returning to the instrumented Bash shell. This change intentionally does not edit remote rc files, preserve unsafe environment variables through sudo, or rewrite user commands.Closes #69
Addresses #70