Add k.klaus and constrain MLE estimates to correct sign#153
Open
bmcafee wants to merge 11 commits into
Open
Conversation
updates from main repository
bmcafee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds the k.klaus and k.klaus.base functions. This k600 model is based on the work of Klaus and Vachon (2020, Aquatic Sciences). Per their paper, this model "is designed to fit average conditions across a wide range of global lakes". The implementation here does not account for the uncertainty included in the original model in order to be consistent with the other models in LakeMetabolizer. This uncertainty should ideally be added in a future update.
This update also constrains GPP and R in the metab.mle to be positive and negative, respectively. This was supposed to be a separate request but I forgot to make a separate branch. Too late now.