Update ExtData.yaml files to use science quality QFED3 emissions (develop)#393
Draft
Update ExtData.yaml files to use science quality QFED3 emissions (develop)#393
Conversation
# Conflicts: # CHANGELOG.md # CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE
When updating the GEOSgcm fixture, this should be taken with ACHEM v1.1.0 which has as similar fix from @acollow (see GEOS-ESM/ACHEM#6)
This is essentially #390 for develop (as #390 was released as v2.3.1).
Question for @acollow: Can you make sure the
valid_rangeandstarting_datehere make sense fordevelop. All we did was a straight merge and so it started from what you had in v2.3.1 and so maybe it needs a different starting date or something.For example:
So, now it says qfed2 is valid until 2025, but the starting for qfed3 is 2023.