Repository navigation
Conversation
…ions - Separate per-user Home Manager options (homeOptions) from system-wide options (systemOptions) in mkFeature - Scope option trees separately for options.modules.home and hostUsers.<user>.modules.home - Pass per-user submodule config directly to Home Manager modules without recursiveUpdate clobbering - Validate requires and recommends paths and throw evaluation error when a required dependency is explicitly disabled - Migrate steam to systemOptions and antigravity, zsh, git, and clavis to homeOptions
- Remove freeformType fallback from hostUsers.<user>.modules submodule - Change extraGroups default from [ "wheel" ] to [ ] and add explicit trustedNixUser option - Enable trustedNixUser for dgarifullin in hosts/users/dgarifullin.nix - Merge userDefaults.antigravity on nix-goldstar and remove impure CONTEXT7_API_KEY builtins.getEnv call
- Accept hostName in mkDarwinConfiguration and mkNixosConfiguration and append privateExtension.hosts.<host>.modules - Pass --override-input private-extension when DOT_PRIVATE_EXTENSION is set in justfile
… conflicts - Assert unprivileged user bob is excluded from wheel group and nix.settings.trusted-users - Add scoped-options-and-requires check testing systemOptions, homeOptions, and hard requires conflict detection
- Replace remaining mkModuleV2 and home.core references in README.md and dotfiles-management skill - Document homeOptions, systemOptions, and recommends in AGENTS.md and nix-module-creation skill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the follow-up architectural review items on
mkFeature:homeOptionsandsystemOptions(lib/features.nix):extraOptionswithhomeOptions(exposed underhostUsers.<user>.modules.home.*) andsystemOptions(exposed underoptions.modules.home.*).lib.recursiveUpdatebetween global and per-userfeatureCfgso per-user option defaults never overwrite global values.steamtosystemOptionsandantigravity,zsh,git, andclavistohomeOptions.modules/_core/user.nix):freeformType = types.attrsOf types.anything;fromhostUsers.<user>.modules.requiresvsrecommends):requiresandrecommendspaths exist inmoduleMap.requiresa module that the user explicitly disabled (enable = false), while still allowingenable = falseto override category cascades andrecommends.justfileOverride:mkDarwinConfigurationandmkNixosConfigurationto accepthostNameand appendprivateExtension.hosts.${hostName}.modules or [ ].DOT_PRIVATE_EXTENSIONintojustfilerebuild/check recipes.hostUsers.<user>.extraGroupsto[ ]and adds explicittrustedNixUser(defaultfalse).builtins.getEnv "CONTEXT7_API_KEY"fromnix-goldstar.README.mdand.agents/skills to remove stalemkModuleV2andhome.corereferences.checks.nixwithscoped-options-and-requiresand unprivileged user assertions.