Repository navigation
Record final signing outcomes and sealed caller context in History - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing audits are now emitted only after the final caller and policy recheck, preventing an allowed History row for a signature that was ultimately dropped. Requested operation and verified caller/explicit uncertainty are stored inside encrypted sensitive details, shown in History, searchable through existing text filtering, and redacted in exports. Old audit rows retain their existing interpretation.
The default rapid-signing presenter refuses interactive test-run dialogs; injected test presenters remain supported.
Validation: all 927 tests passed (543 core, 384 app), including final-policy rejection without duplicate allowed audit, once-only uncertainty, encrypted round trips, legacy row decoding, redacted/unreadable exports, History regressions, and noninteractive test prompts. 309 changed lines. Targets ui/refactor; installed app unchanged.