Repository navigation
Stop login prompt retries caused by restored window focus - #196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling the Clavis login prompt previously suppressed focus-triggered retries for only one second. A later key-window event could prompt again without a deliberate retry. Automatic authentication now runs once per locked period; Unlock and explicitly reopening Clavis remain available to retry. Idle/manual locking does not immediately unlock itself.
Authentication completions are tied to a lock generation, so locking the screen while an attempt is pending discards and invalidates its result. Production authentication adapters refuse system prompts inside test processes; tests must inject fakes.
Validation: 48 focused login and audit tests passed, including focus storms, cancellation after long delays, explicit retry/reopen, stale completions, and test-authentication safeguards. Native inspection is pending because the Mac is locked. The installed v0.4.5 app has not been replaced. Integration target:
ui/refactoronly.