Repository navigation
Separate key type and capabilities with conservative record migration - #193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates Personal/Bot type from independent SSH/Signature capabilities in authenticated private records. Version 2 records decode with their original restrictions and round-trip without rewriting key material; version 3 stores the independent profile. Rename, type changes, repair, and the sidebar preserve that profile.
Signing checks capabilities against the authenticated record. Cache/profile disagreements fail closed rather than restoring a potentially broader vault backup. Existing purpose and socket restrictions remain additional constraints until caller authorization is integrated. Existing approval settings are unchanged. Older binaries refuse version 3 records.
Validation: 480 core and 345 app tests passed, including migration, capability combinations, strict decoding, and stale-cache signing refusal. A full run hit a socket-test SIGPIPE; the core rerun passed. 301 changed lines. Local commit is unsigned because no signing identity is available.
Integration target:
ui/refactoronly.