This repository was archived by the owner on Mar 16, 2021. It is now read-only.
Feature: getViewOrThrow() in onAttachView() Lint-Check#160
Closed
jreehuis wants to merge 13 commits into
Closed
Conversation
…Presenter.onAttachView
…row_in_onattach # Conflicts: # thirtyinch-lint/src/main/kotlin/net/grandcentrix/thirtyinch/lint/TiLintRegistry.kt
Contributor
How can this happen? 🤔
Why should someone call Do we need to update the annotation here - when its possible to have a |
Contributor
|
This lint warning could hint to use the parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new lint check to detect a direct or transitive call of
TiPresenter.getViewOrThrow()inTiPresenter.onAttachView().In
TiPresenter.onAttachView()the view of the presenter might still be null. So callingTiPresenter.getViewOrThrow()would throw an exception during runtime.In production this usually crashes the App. This behaviour is correct to detect the issue later on.
With this lint check the issue can be easily detected already during development.
Merge Information
Merge after #158 as this PR uses the Lint Check implementation of #158 as foundation.