Move travis to docker by StefMa · Pull Request #116 · GCX-HCI/ThirtyInch

StefMa · 2017-09-26T14:32:03Z

Based on #115

Do two build environments: unit and instrumentation (run in parallel)
Moved unit test to docker (because of the andoird images you can't really start a emulator in docker)

Benefits of using docker:

The docker image contains only the "sdkamanger". The sdkmanager install every build-tools or android images if they needed automatically. We don't need to update the travis.yml anymore \o\
We can trust the docker. If the underlined host (travis <-> trusty, zenty) changed, everything just works as before. As long as we can run docker in that environment.

Benefits of the new travisscript:

It parses automatically the BUILD_TOOLS_VERSION and the SDK_VERSION from the build.gradle file and put it into the the travis android components. We don't need to update the travis.yml anymore /o/

Do we have speed benefits?

Unfortunately not really. Because travis is very slow with starting a emulator and stuff it won't decrease the build time. Maybe 10 seconds or so because travis don't run the unit tests anymore :)

What do test:

If codecov works as aspected -> Checked ✅ works

StefMa · 2017-09-27T06:56:27Z

Seems that UnitTests are working now in docker 👍
That is great...
Moving now InstrumentationTests back to travis...

StefMa · 2017-09-27T07:01:00Z

Read also that: https://docs.travis-ci.com/user/speeding-up-the-build/

Thinking about to have two parallel builds:

Native for Instrumentation Tests
Docker for Junit, codecov etc.

StefMa · 2017-09-27T10:13:57Z

\o/ 💛 :awesome: :sweet: 🍬

Here is a 🌮

StefMa · 2017-09-27T10:18:45Z

Next step is to cache the dependencies
https://docs.travis-ci.com/user/caching/

And other 🍬 :

Read the android components from a file instead of having it directly in the travis.yml. Maybe we can read the build-tools and sdkVersion from the build.gradle somehow 🤔

passsy · 2017-09-27T11:47:59Z

+
+before_install:
+  - if [ $TEST_SUITE == "unit" ]; then
+    docker pull stefma-docker-hub.bintray.io/android-build-env:0.1-alpha;


how can we update this docker image?

It is an open source project.
you can find it here: https://github.com/StefMa/AndroidBuildEnv

StefMa · 2017-09-27T11:51:36Z

Don't cache.
Because we can't really delete the cache ...
Make no sense with that mechanism...

* Splitting unit and instrumentation tests * Let's run unit tests in docker

passsy · 2017-09-27T12:52:19Z

-    - sys-img-armeabi-v7a-android-22
-
-
+    - $(if [ $TEST_SUITE == "instrumentation" ]; then echo "tools,platform-tools,tools,build-tools-26.0.1,android-22,android-26,extra-google-google_play_services,extra-google-m2repository,extra-android-m2repository,addon-google_apis-google-24,sys-img-armeabi-v7a-android-22"; fi)


can we make the echo multiline?

Currently I create a script.sh which reads the BUILD_TOOLS_VERSION and SDK_VERSION and replace the given numbers.
These script return then all components..

passsy · 2017-09-27T12:57:51Z

+before_install:
+  - if [ $TEST_SUITE == "unit" ]; then
+    docker pull stefma-docker-hub.bintray.io/android-build-env:0.1-alpha;
+    docker run -i -v $PWD:/project -t stefma-docker-hub.bintray.io/android-build-env:0.1-alpha /bin/bash -c "./gradlew build jacocoTestReport";


move this to the script section

StefMa · 2017-09-27T13:49:11Z

🤦‍♂️

StefMa · 2017-09-28T07:48:52Z

Currently build-tools got not parsed correctly..

StefMa · 2017-09-28T09:48:09Z

Rebased all.
Works now 👊

Problem was that \' is valid on "mac sed" but not on "gnu sed".
Replaced it with just '. Works on both sed versions...

StefMa · 2017-09-28T11:16:23Z

If codecov works as aspected

Seems that codecov is reporting fine \o/
See https://codecov.io/gh/grandcentrix/ThirtyInch/compare/7533ea03c848ab39911356fe2965e51070094d7e...5c2ba57fdf35738b40d97bff013b9565fdb2625e

passsy · 2017-09-28T12:51:46Z

+
+# Read the BUILD_TOOL_VERSION and COMPILE_SDK_VERSION
+BUILD_TOOLS_VERSION=$(cat build.gradle | grep "BUILD_TOOLS_VERSION*" | sed -e "s/^.*'\(.*\)'/\1/")
+COMPILE_SDK_VERSION=$(cat build.gradle | grep "COMPILE_SDK_VERSION*" | sed -e "s/^.*= \(.*\)$/\1/")


can we put this in the .travis.yml, too?

No. Unfortunately this isn't possible because of the limitations of the travis.yml file

StefMa added the do not merge label Sep 26, 2017

passsy reviewed Sep 27, 2017

View reviewed changes

Update travis:

d6d91ec

* Splitting unit and instrumentation tests * Let's run unit tests in docker

StefMa force-pushed the feature/move_travis_to_docker branch from 3d6443d to d6d91ec Compare September 27, 2017 12:21

passsy reviewed Sep 27, 2017

View reviewed changes

StefMa force-pushed the feature/move_travis_to_docker branch 2 times, most recently from bb055cc to 4efa5da Compare September 28, 2017 07:37

Move docker run into script

d08f7e7

StefMa force-pushed the feature/move_travis_to_docker branch from 4efa5da to 70d8af7 Compare September 28, 2017 07:47

Extract android components to its own script

5c2ba57

StefMa force-pushed the feature/move_travis_to_docker branch from 68bd304 to 5c2ba57 Compare September 28, 2017 09:46

passsy reviewed Sep 28, 2017

View reviewed changes

StefMa force-pushed the feature/move_travis_to_docker branch 2 times, most recently from 4c4569d to 5c2ba57 Compare September 29, 2017 09:14

StefMa added Ready for Review and removed do not merge labels Sep 29, 2017

passsy mentioned this pull request Sep 29, 2017

Get rid of instrumentation tests #119

Open

StefMa closed this Oct 26, 2018

StefMa deleted the feature/move_travis_to_docker branch October 26, 2018 10:34

		- sys-img-armeabi-v7a-android-22


		- $(if [ $TEST_SUITE == "instrumentation" ]; then echo "tools,platform-tools,tools,build-tools-26.0.1,android-22,android-26,extra-google-google_play_services,extra-google-m2repository,extra-android-m2repository,addon-google_apis-google-24,sys-img-armeabi-v7a-android-22"; fi)

Conversation

StefMa commented Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefMa commented Sep 27, 2017

Uh oh!

StefMa commented Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefMa commented Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefMa commented Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

passsy Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

StefMa Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

StefMa commented Sep 27, 2017

Uh oh!

passsy Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

StefMa Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

passsy Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

StefMa commented Sep 27, 2017

Uh oh!

StefMa commented Sep 28, 2017

Uh oh!

StefMa commented Sep 28, 2017

Uh oh!

StefMa commented Sep 28, 2017

Uh oh!

passsy Sep 28, 2017

Choose a reason for hiding this comment

Uh oh!

StefMa Sep 29, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

StefMa commented Sep 26, 2017 •

edited

Loading

StefMa commented Sep 27, 2017 •

edited

Loading

StefMa commented Sep 27, 2017 •

edited

Loading

StefMa commented Sep 27, 2017 •

edited

Loading