Repository navigation
fix(genui): repair incomplete output without user-message bubbles - #3771
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incomplete OpenUI output can render a partial card while losing later statements. Forward the parser's
incompleteandunresolvedmetadata to host diagnostics, and automatically request repair for structural failures and missing content. Ordinary property warnings keep the card interactive.Make repair eligible for deferred GenUI calls that first mount after generation while their owning turn is still live. Keep host repair evidence in stored context while omitting its internal user-message bubble and virtual row from the transcript. Also clarify the deferred tool description so agents can choose GenUI proactively when an interactive, vivid presentation helps.
Type and Areas
Type: Bug fix / UI/UX
Areas: Web UI GenUI, FlowChat, Rust tool description
Motivation / Impact
A missing closing delimiter previously surfaced only as downstream property errors, leaving missing content without automatic repair. Structural diagnostics now prioritize the root cause in repair requests. Degraded cards remain usable during repair; existing active-surface admission, persisted deduplication and repair limits remain in place. Completed historical cards do not start automatic repair when reopened.
Verification
pnpm --dir src/web-ui exec node scripts/run-vitest.mjs run src/tools/generative-ui src/tools/generative-widget/GenerativeWidgetPanel.test.tsx src/flow_chat/components/modern/UserMessageItem.test.tsx src/flow_chat/store/modernFlowChatStore.test.ts --maxWorkers=2— 27 files, 545 tests.pnpm run check:web— includes TypeScript checking and Appearance checks.cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,tools-miniapp,git --lib -- generative_ui— 5 tests.git diff --check upstream/main...HEAD.Reviewer Notes
Uses existing OpenUI parse metadata rather than a second parser. No new persistence shape or network protocol. The complete GenUI specification remains deferred.
Checklist