Repository navigation
feat(office): add charts, equations and font inheritance controls - #3768
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenOfficeFile can now create editable Excel charts and Word equations directly, preserve content during incremental edits, and style mixed-language text without forcing one font across every script. Word, Excel and PowerPoint now share explicit font defaults, recovery instructions and verification status across the tool prompt, schema and guides.
Type and Areas
Type: Feature, bug fix, tool guidance, regression tests.
Areas: Portable Office document engine; Core GenOfficeFile tool; DOCX/XLSX/PPTX guides.
Motivation / Impact
add_chart,replace_chartanddelete_chart, with schema/guide examples and readable model output. Charts reference worksheet ranges and carry caches for immediate display. Sheet renames and row/column edits update their references; deleted sources produce explicit warnings.fontbehavior while adding locallatin_font,east_asia_fontandcomplex_script_fontoverrides for Word/PPT, plus complex-script document/theme defaults. An intended Latin-only change can now leave East Asian inheritance intact. PPT paragraph/run/element precedence is explicit.format_range.reset_fontto remove only the font name while preserving values, formulas and all other formatting. Stop classifying every custom Excel font as sans-serif.fonts_verified:falseon writes and reads, with an explicit target-viewer caveat. Structural warnings and valid Unicode do not prove correct glyph rendering.Verification
cargo test --locked -p openbitfun-office-documents— 30 unit tests and 22 integration tests passed.cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git,tools-office-documents --lib agentic::tools::implementations::gen_office_file_tool::tests— 6 tests passed.pnpm run fmt:rs,pnpm run check:core-boundaries,pnpm run check:repo-hygiene, andgit diff --check— passed.Reviewer Notes
math-core(MIT, default features disabled) parses LaTeX; existingroxmltreemoves from test-only to runtime use for the MathML bridge. No Office/TeX executable, platform API or host process is introduced.fontscopes and Excel null-as-no-op behavior remain compatible. Older engines preserve unknown model fields but cannot render new chart/equation capabilities. Existing file envelopes, workspace routing and wire protocols are unchanged.Checklist