feat(web-ui): follow system theme and persist selection#252
Merged
bobleer merged 1 commit intoGCWing:mainfrom Mar 24, 2026
Merged
feat(web-ui): follow system theme and persist selection#252bobleer merged 1 commit intoGCWing:mainfrom
bobleer merged 1 commit intoGCWing:mainfrom
Conversation
- Add system theme option with OS preference resolution and listener cleanup\n- Split theme selection vs resolved theme id in ThemeService and store\n- Wire onboarding and basics settings; i18n for en-US and zh-CN\n- Optimize Logo-ICON.png asset size Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a follow system theme option for the web UI. Theme selection (including
system) is persisted separately from the resolved built-in theme id, with OS preference and media-query listener cleanup handled in ThemeService.Changes
SYSTEM_THEME_ID,ThemeSelectionId, resolved vs selection state, and safe handling when unregistering themes.Logo-ICON.pngoptimized for smaller file size;index.htmladjusted as needed.Testing
Made with Cursor