Make broken-page recovery obvious for casual users - #8
Merged
Merged
Conversation
Show a plain-language Page not working? card in the popup with one-click pause and reload, upgrade it when Static has a compatibility warning, and actually let paused sites through the global fingerprint/CAPTCHA network lists.
Playwright opens popup.html as a tab, so point it at the http tab via tabId and install pause-allow DNR rules through storage updates instead of service-worker sendMessage.
Keep both Unreleased changelog entries: popup recovery UX from this branch and learned WAR-path Noise coverage from main.
The pause-allow retry path named webtransport/webbundle, which the Firefox zip self-check forbids. Filter those types without quoting them, and blank leftover quoted names during the Firefox build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Static can break some sites (logins, checkouts, anti-bot/CAPTCHA flows, pages that mishandle blocked extension probes). Advanced users already know to pause the origin or toggle rulesets. Casual users often do not:
fetch).unhandled page error,extension-probe fetch).We also should not inject an in-page banner. That would be another Static fingerprint.
Approach
Keep recovery inside the toolbar popup, but make it the default casual path:
!so people notice they should open the popup.allowrule for that host, so fingerprint/CAPTCHA vendor blocks stop applying to that site. Resume removes the rule.Static still does not auto-disable itself.
Test plan
allowrule; resume removes it!for a fresh compatibility warningResults
npm run test:static: 42 passed, 1 skipped (Firefox zip test now also passing locally withCI=1)main: 14 passednode build-firefox.jsself-check: passed after removing leftoverwebtransport/webbundlestring literals from the pause-allow retry path