Repository navigation
Conversation
addidotlol
requested changes
Nov 6, 2026
Comment on lines
+2
to
+13
| """Backfill Fyra Stack SMBIOS type 1 branding onto existing VMs. | ||
|
|
||
| Run as root on any PVE cluster node. Dry-run by default; pass --apply to write. | ||
|
|
||
| CSV columns (header optional): stable_id,proxmox_id,tier | ||
| 01JABCDEFGHJKMNPQRSTVWXYZ0,1234,s1.small | ||
|
|
||
| Mirrors smbios1Branding()/rebrandSmbios1() in | ||
| apps/dashboard/src/lib/server/backends/proxmox/index.ts: sets manufacturer/family | ||
| to "Fyra Stack", product to the tier, serial to the stable id, and keeps the | ||
| existing SMBIOS UUID (plus any other fields). Takes effect on next cold boot. | ||
| """ |
Member
There was a problem hiding this comment.
i don't believe this change is really worth backfilling since its purely cosmetic. lea currently is unsure if its worth it, maybe fine to just 86 this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.