Repository navigation
Refactor/reduce complexity - #12
Merged
Merged
Conversation
With no visible sample (after a reload, Clear, or a preserve-log mode
change) the 'all' x-axis had no min, so Chart.js fell back to 0..1 and
every tick read as an offset from the Unix epoch ("-1790596532s"). With
exactly one sample min === max, a zero-width axis Chart.js will not widen
because both bounds are user-set.
The axis now starts at the first visible sample, or at now when there is
none, and spans at least 10 s (ALL_MIN_SPAN_MS) so the whole-second tick
labels never repeat. Like a bounded window still filling, the trace grows
rightward until the session is longer than that.
Bump to 2.1.1.
Behaviour-preserving extractions only, measured with fallow health: - Sidebar: status label/colour from a STATUS_VIEW table (cog 16 -> 10) - buildLsdHistogram: dominantValue() helper, Math.min/max in the window loop (26 -> 13) - DataLog filtered scan: one matches(r) predicate, same order and short-circuiting (20 -> 10) - readLoop: per-chunk handling in a deliver closure, errorText() shared with connect (31 -> 18) - chart update effect: pure xAxisBounds() and yAxisFloor() helpers (39 -> 27) Functions over the complexity thresholds 12 -> 9; project cognitive total 1034 -> 993.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.