Repository navigation
counter: no tender until the cashier chooses one - #148
Merged
Merged
Conversation
Five legs that fail on today's counter, which starts every sale on cash, puts cash back after a sale and after an account tender, and lets Pay complete the sale in cash for the whole amount. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
The tender starts empty, is empty again after a completed sale, a new sale, Clear sale, Clear tenders and Add as split tender. With none chosen, Pay is off and says "Choose how the customer pays", the amount field and Add as split tender are off, and the summary reads None yet. Older legs that assumed cash was preselected now press cash first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
…the total Pay now reads "Choose how the customer pays" until a tender is pressed, so the walk asserts that, presses cash, and then reads the total on Pay. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
typeInto no longer chooses cash when none is pressed; each leg that types an amount chooses its tender, so a leg that means to type with no method is not tested on cash without saying so. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
…s the method (red) The Clear sale leg fails today: an $86.50 cash tender added as a split survives Clear sale, so a $50.00 line is payable with no tender pressed. The Clear tenders leg guards the existing reset against a later undo. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
… (red) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
…nder Clear sale drops the tenders added for the cleared lines as well as the chosen method. Naming another customer or going back to a walk in sale clears the chosen and added tenders, so an account tender chosen for one customer never carries to another. A tender cannot be pressed while no till is open. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
… none A second arm for the Clear sale reset: press a tender without adding it, Clear sale, put a new line on the sale, and no tender is pressed and Pay is off. It fails with the reset removed (the review's M4) and passes with it back. Clear sale and Clear tenders now use the one reset helper. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counter no longer assumes a tender. A sale started on cash and put cash back after a sale or an account tender, and Pay completed the sale in cash for the whole amount while the Payment panel showed Cash as chosen. An "on account" sale was paid in cash and the account never carried the charge.
Red first: the first commit holds five Vitest legs that fail on the old code (pressed tender and Pay state, Pay not completing, the account tender sent as
account, no tender after New sale, none after a split). Older legs that relied on the cash default now press cash first.Scope: item 130, note N1.
🤖 Generated with Claude Code