fix: resolve 4 compile errors for windows-crate 0.58 and rtrb 0.3#1
Merged
Conversation
- capture: pass SendHandle (not .0) to capture_loop so Rust 2024 precision-capture picks up the Send impl rather than the bare HANDLE - capture: change capture_loop parameter to SendHandle; access .0 at use site inside the function - capture: declare write_chunk_uninit result as `mut chunk` so as_mut_slices() can take &mut self - capture: wrap commit_all() in unsafe block (rtrb 0.3 marks it unsafe) - devices: PROPVARIANT in windows-core 0.58 is opaque; read pwszVal at the known ABI offset (byte 8) via read_unaligned instead of field path https://claude.ai/code/session_014Yfiz8nJA1Lh8eNbJ6e9B7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mut chunkso as_mut_slices() can take &mut selfhttps://claude.ai/code/session_014Yfiz8nJA1Lh8eNbJ6e9B7