Queue: fix-service-active-check - #88
Draft
Alaraajavamma wants to merge 1 commit into
Draft
Conversation
Alaraajavamma
force-pushed
the
feature/forky/fix-service-active-check
branch
from
August 13, 2026 18:09
6b02cc1 to
d35b47b
Compare
Unpacking a reply already unwraps the variant inside it, so asking the result to unwrap again reaches a plain string or list and raises. Every one of these sits in a try, so nothing was ever reported: asking whether the telephony service was active always answered no, which meant it was started again on a path that only wanted to know, and the tmate session gave up on bringing the mobile connection up before it had found which device to bring up.
Alaraajavamma
force-pushed
the
feature/forky/fix-service-active-check
branch
from
August 14, 2026 21:15
d35b47b to
2d20d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued behind the open review queue; will get its real title and body when it is marked ready.
Unpacking a D-Bus property reply already unwraps the variant inside it, so the second unwrap reaches a plain str or list and raises. Three sites, all inside a try, so it never surfaced: the service-active check always answered no, and the tmate path abandoned bringing mobile data up before it had found the device — the case that feature exists for.