fix: HUD caption icon, in-place list sync, and compact progress - #5
Merged
Conversation
WinUI windows now SetIcon from a 16/32/48 BMP ICO. Sync updates bound rows by Id instead of Clear(), and the HUD shows settled progress plus colored compact status chips. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
The XAML compiler rejects Window.Resources (WMC0011). Put the compact row style on the root Grid and keep the x:Bind templates inline. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First-run HUD on Win11 25H2 (FUNCULAR-WKS-02) showed a generic caption icon, airy monochrome rows with the same elapsed clock on every line, and a mid-tick flash where both ListViews went empty while the footer kept counting.
ApplicationIconreaches the exe/taskbar but WinUIWindowdoes not.WindowIcon.ApplycallsAppWindow.SetIconafterGetFromWindowIdon MainWindow, SettingsWindow, and ConsentWindow. The 195-byte PNG-in-ICO is replaced with a 16/32/48 BMP glyph derived from the existing teal mark.HudViewModel.Syncno longerClear()s bound collections.CollectionSync.InPlacematches by Id,Apply()s existing rows, inserts new, removes missing, and preserves order. Footer elapsed still ticks every second.N / M settled(Interactive / Failed / Hung / Disabled are terminal; Pending / Starting are not), compact single-line rows, colored status chips (green / amber / purple / orange / gray). Per-row clocks that duplicated the footer are gone. No admin, hooks, or extra windows.WindowsAppSDKSelfContainedstaysfalse. CommunityToolkit.WinUI stays gone. Tests stay out of the slnx.Test plan
dotnet test tests/Reentry.Core.Tests/Reentry.Core.Tests.csproj -c Release— 51 passed (includes CollectionSync in-place / no Reset, andAppState.IsSettled)dotnet build Reentry.slnx -c Release— Windows CI green (9541310)