fix: include Reentry.Core in slnx for Visual Studio restore - #3
Merged
Conversation
Visual Studio NU1105: Core is a ProjectReference but was not in the solution. Map both projects to x64; Core now declares Platforms x64 so the mapping is valid. Keep net10.0 and leave tests out of the slnx. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
piranout
marked this pull request as ready for review
August 20, 2026 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2 (already merged). The x64 pin (and a local
<Platform Project="x64" />on App) cleared the unknown-configuration banner. Rebuild then failed:Reentry.Coreis aProjectReferencefrom App but was not in the slnx.Change
src/Reentry.Core/Reentry.Core.csprojunder/src/.<Platforms>x64</Platforms>so the slnx mapping is valid. TFM staysnet10.0(not-windows).x86;x64;ARM64. Tests stay out of the slnx.Verify
dotnet test tests/Reentry.Core.Tests— 39 passeddotnet build Reentry.slnx -c Release