fix: visual-column tiles, tree keyboard, first-click (0.8.5 + 0.8.6-beta1) - #6
Merged
Merged
Conversation
0.8.4 stepped by a width-based column count that came out one low once the wrap viewport already excluded the scrollbar (4 visual columns, nav used 3). Pick by layout X and never undercut columns seen on screen. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
WPF codegen rejected `{ [sorted[0]] }` as a dictionary initializer.
Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
WPF codegen on WKS-02 rejects [] / collection-init sugar (CS1003/CS1525). Use Array.Empty and explicit List<T> only. No LangVersion bump. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
Tab/Shift+Tab cycle only the folder tree and the tile list; the ribbon and Everything are not stops. Click or Tab onto the tree focuses it so Up/Down move folders immediately, without changing the destination selection. Tree selection commits first. Tile rebuild is last-one-wins off the UI thread, generation-stamped at request time, and applied at Background so queued arrows are not gated on grid render. The existing Loading spinner covers a slow rebuild after the node has already moved. UNVERIFIED: live WPF Tab/arrow/spinner timing on a large library (unit tests cover the focus policy, not dispatcher interleaving).
The click that activates Aperture is passed through (MA_ACTIVATE, not eaten). A click on a tile when another pane had keyboard focus focuses that tile in the same click, matching Explorer. UNVERIFIED: live inactive-window click-through on a real desktop session.
…eta1) TreeViewItem.Focus() selects the node. PreviewMouseDown now classifies the hit: folder row still same-click focuses; expand chevron, include checkbox, and alias edit leave the selected folder alone. UNVERIFIED: live WPF expander/checkbox click with the tree unfocused.
piranout
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.8.5 + 0.8.6-beta1 on one PR (tile visual-column, tree keyboard, first-click).
0.8.5-beta1
0.8.6-beta1
Tests
dotnet test tests/Aperture.Core.Tests/Aperture.Core.Tests.csproj -c Release307 passed.
Version 0.8.6-beta1.