fix: Explorer-style tile-pane arrows, Page, and Tab (0.8.4-beta1) - #5
Merged
Conversation
Up/Down stay in the same visual column (including across date-section headers). PageUp/PageDown move one viewport and keep the same column at the same screen Y. Tab cycles only tree ↔ tile pane and does not change either selection; the ribbon is not a Tab stop. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
The helper prefers the same column when any cell is in it. The old fixture included a col-3 tile on the previous row, so the expected short-row fallback never applied. Co-authored-by: Paul Smith <piranout@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keyboard navigation in the tile pane did not match Explorer.
Up/Down used the existing
MoveGridpath, which walks a linear NavStop list (headers + tiles) by±columns. In a wrapping, date-sectioned grid that looks random: short last rows throw the index off, and Down often lands on the next section header instead of the tile in the same column.PageUp/PageDown were not handled at all, so ListBox default (skip N items / jump to a header) ran.
Tab walked the ribbon (hamburger, command bar, search) and
OnEverythingKeyDownselected the first tile when entering the grid. WPF ListBox/TreeView also select the first item on focus.Fix
TileSpatialNavigation: layout-based 2D pick over wrap + section gaps (headers are not cells).KeyboardNavigation.TabNavigationisOnceon the folder pane and the tile ListBox,Noneon the ribbon / status / preview. Search stays on/and Ctrl+F.LibraryPaneFocus.ShouldKeepExistingSelection+ PreviewGotKeyboardFocus). Canvas-click focus (LibraryPaneFocus/ItemsList.Focus()from PR fix: focus the tile pane when clicking its empty canvas (0.8.3-beta1) #4) is unchanged; spatial arrows and Page keys work after that focus.Version is 0.8.4-beta1 in
Aperture.App.csproj. CHANGELOG has## [0.8.4-beta1].How to test
dotnet test tests/Aperture.Core.Tests/Aperture.Core.Tests.csproj—TileSpatialNavigationTests(same column, page = one viewport, not skip-N) andLibraryPaneFocusTests(canvas claim + Tab must not move selection). Live WPF is not unit-tested.Manual path (the real check):
/and Ctrl+F.Notes
v0.8.4-beta1.