Skip to content

fix: github_copilot_sdk.py - prioritize BYOK_MODELS over API fetch when explicitly configured #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fu-Jie merged 1 commit into from
May 10, 2026
Merged

fix: github_copilot_sdk.py - prioritize BYOK_MODELS over API fetch when explicitly configured #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions plugins/pipes/github-copilot-sdk/github_copilot_sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8133,7 +8133,15 @@ async def _fetch_byok_models(
) or self.valves.BYOK_BEARER_TOKEN
effective_models = (uv.BYOK_MODELS if uv else "") or self.valves.BYOK_MODELS

if effective_base_url:
# If user explicitly configured BYOK_MODELS, use them directly (skip API fetch)
if effective_models.strip():
model_list = [
m.strip() for m in effective_models.split(",") if m.strip()
]
await self._emit_debug_log(
f"BYOK: Using user-configured BYOK_MODELS ({len(model_list)} models)."
)
elif effective_base_url:
Comment on lines +8137 to +8144
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current logic checks effective_models.strip() to decide whether to skip the API fetch. However, if effective_models contains only delimiters (e.g., ", ,"), model_list will be empty, yet the API fetch will still be skipped because the condition is truthy. It is more robust to parse the models first and only skip the API fetch if the resulting list is non-empty.

        model_list = [m.strip() for m in effective_models.split(",") if m.strip()]
        if model_list:
            await self._emit_debug_log(
                f"BYOK: Using user-configured BYOK_MODELS ({len(model_list)} models)."
            )
        elif effective_base_url:

try:
base_url = effective_base_url.rstrip("/")
url = f"{base_url}/models"
Expand Down Expand Up @@ -8188,16 +8196,6 @@ async def _fetch_byok_models(
except Exception as e:
await self._emit_debug_log(f"BYOK: Setup error: {e}")

# Fallback to configured list or defaults
if not model_list:
if effective_models.strip():
model_list = [
m.strip() for m in effective_models.split(",") if m.strip()
]
await self._emit_debug_log(
f"BYOK: Using user-configured BYOK_MODELS ({len(model_list)} models)."
)

# Infer per-model provider from ID string (BYOK endpoints can return multi-provider lists)
byok_models = [
{
Expand Down
Loading