feat: add interactive selection dialog to batch installer#60
Conversation
✅ Plugin Version Check / 插件版本检查版本更新检测通过！PR 包含版本变化和更新说明。 Version check passed! PR contains version changes and update description. 版本变化 / Version ChangesPlugin Updates
This comment was generated automatically. / 此评论由自动生成。 |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for the Batch Install Plugins tool by introducing an interactive selection dialog. Instead of a simple confirmation, users can now review a filtered list of plugins in a browser-based dialog, selectively check which ones they wish to install, and proceed with only their chosen subset. This change provides greater control and flexibility during the batch installation process, making plugin management more intuitive and less "all-or-nothing." Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant improvement to the 'Batch Install Plugins' tool by replacing the simple confirmation dialog with a fully interactive selection dialog. This allows users to choose exactly which plugins to install from a discovered list. The implementation involves generating and executing a substantial JavaScript payload to render the UI. The version is bumped to 1.1.0, and all related documentation, including READMEs, release notes, and docs pages, have been updated accordingly in both English and Chinese. The core logic change is well-implemented, and error handling seems robust. My main feedback is on improving the maintainability of the embedded JavaScript code.
| def _build_selection_dialog_js( | ||
| options: List[Dict[str, str]], | ||
| ui_text: Dict[str, str], | ||
| ) -> str: |
There was a problem hiding this comment.
This function generates a large block of JavaScript with extensive inline CSS, which can be difficult to read and maintain. For better readability and separation of concerns, consider defining the CSS in a separate <style> block. You can create a <style> element dynamically in JavaScript, append it to the document's <head>, and then use CSS classes in your HTML template string. This would make the HTML structure much cleaner and the styles easier to manage.
1 participant
Changes
Validation
Scope