Authenticate - #19
Open
MrFjellstad wants to merge 12 commits into
Open
Authenticate#19MrFjellstad wants to merge 12 commits into
MrFjellstad wants to merge 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
put a example secret in config.js.example and put the local secret in config.js
Contributor
|
How much do you think it will it take to get this finished? |
Contributor
Author
|
The splitting out in to separate authentication module is still missing! |
Contributor
|
check this https://github.com/petteraas/retrospectacular/tree/MrFjellstad-authenticate_2 it's written on top of your code from this pr. it adds a user type to the index template, simple CRUD for user, it creates a new user in ES ( or loads existing ) based on the Google authenticate (displayName is probably not the best field to check for, but it works for now). it uses redis as session store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more a RFC, so don't just wack it in!
It is lacking a good error response when you try to access resources you don't have access to in the frontend, but that is easy to fix.
It is blocking the wordcloud if you don't authenticate. This is by design, and meant as an example.
The backend needs more work on the user management. It needs to store the user and maybe give it an id so we can use it for something useful!