support for Amiga protection bits and create_system#1
support for Amiga protection bits and create_system#1sonnenscheinchen wants to merge 9 commits intoFrodeSolheim:mainfrom
Conversation
|
Hi, sorry for the delay, I'll test and pull this in eventually, I just have been busy. Thanks for contributing back :) |
|
No problem, take your time and keep up your excellent work on fs-uae. :-) I started making some extract-tools which can automatically create .uaem-files for fs-uae, but there is still a lot of work to do. Maybe some day we see something similar for fs-uae-launcher... :-) |
|
You should rebase your pull request branch to remove the merge commits. |
lhafile/lhafile.py
Outdated
| 0x43: 'CP/M', 0x46: 'FLEX', 0x6D: 'Macintosh', 0x52: 'Runser', | ||
| 0x54: 'TownOS', 0x58: 'XOSK', 0x77: 'Windows95', 0x57: 'WindowsNT', | ||
| 0x00: 'MS-DOS', 0x4A: 'Java' } | ||
| create_system = os_identifiers.get(os_identifier) |
There was a problem hiding this comment.
Probably should add a default value where so it does not fail when OS identifier is not recognized, e.g.:
create_system = os_identifiers.get(os_identifier, "")
There was a problem hiding this comment.
Hm, it wouldn't really fail. It would be set to None, which may be considered wrong because in fact some system has created the archive. :-) I let it set to an empty string as you suggested.
|
This pull request has been open for an embarrassingly long time, will look over again and aim to merge and do a 0.3.0 release. On another note, I've also set up automated builds via Github actions, so binary wheels for Windows, macOS and Linux are not created (and I upload them to pypi as well). |
…; deleted old README; update README.md
No description provided.