Open
Conversation
ChadSikorra
force-pushed
the
v1-sql-pdo
branch
14 times, most recently
from
72ddeaa to
fccfced
Compare
…nslator to translate an LDAP filter to a SQL where statement (as close as is possible anyway). Support filterable results by storage adapters. Pass storage adapters a broader list of options as a DTO. Return a result object used to indicate if filtering was done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a PDO storage adapter now that there is a pattern for doing this. Implementing it in a way that makes other SQL implementations possible. Though this largely focuses on SQLite. But any PDO style implementation should be possible here. This makes the server storage implementation far more performant, as it only needs to actually filter via PHP under specific filter scenarios.