Allow idUser = 0 and allow submission without answerToken in this case#36
Merged
Conversation
SebastienTainon
changed the title
smadbe
approved these changes
Nov 24, 2025
|
|
||
| export interface PlatformGenericTokenPayload { | ||
| idUser: string|null, | ||
| idUser: string|number|null, |
Contributor
There was a problem hiding this comment.
Without getting fully the context, (IMO) it is a pitty to allow number just for a "test case". If idUser are strings, only strings should be given I would say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: when FioiTaskImporter generates a signed task token to test the task, this token contains idUser = 0. This should be valid, like it was in TaskPlatform. And in this case, the user should be allowed to create a submission on the test task to check that it works correctly.