Skip to content

Fix: Import FN field from vCard 4.0 when N field is missing#497

Open
Tchiller wants to merge 2 commits intoFossifyOrg:mainfrom
Tchiller:fix-vcard-fn-field
Open

Fix: Import FN field from vCard 4.0 when N field is missing#497
Tchiller wants to merge 2 commits intoFossifyOrg:mainfrom
Tchiller:fix-vcard-fn-field

Conversation

@Tchiller
Copy link

@Tchiller Tchiller commented Feb 3, 2026

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

In vCard 4.0, FN is required but N is optional. Previously, contacts
with only FN field were incorrectly imported as organizations with
email addresses shown as the contact name.

Tests performed

I have successfully imported the three vCards which I will attach to this PR on my S22

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • I understand every change in this pull request.

- Remove incorrect logic that treated FN as organization name
- Use FN field directly as contact name when N field is absent
- Fixes FossifyOrg#465
@Tchiller Tchiller requested a review from naveensingh as a code owner February 3, 2026 21:39
@Tchiller
Copy link
Author

Tchiller commented Feb 3, 2026

My three test files:
test-contact-with-n-field.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FN field is not imported from vCard 4.0

1 participant