feat: add Loft primitive that morphs between two 2D cross-sections - #58
Open
hbehrensj wants to merge 2 commits into
Open
feat: add Loft primitive that morphs between two 2D cross-sections#58hbehrensj wants to merge 2 commits into
hbehrensj wants to merge 2 commits into
Conversation
Ports the loft/morph algorithm from hbehrensj/loftmorph as a native parametric shape, mirroring the existing "gear" shape's integration pattern (toolbar entry, geometry builder, viewport render + boolean/ export dispatch, inspector panel, .skf format validation). Bottom and top ends are each independently configurable: shape (Oval/ Rectangle/Triangle/Pentagon/Hexagon), size (bottom follows the shape's own width/depth like every other primitive; top has its own absolute width/depth, mirroring how cone's topRadius works independently of its base), and rotation. Corner-anchored angle sampling keeps polygon corners crisp regardless of segment count or which two shapes are morphing between each other. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gearGeometry.ts (the direct template for this file) has zero comments across 240 lines; keep only the ones that prevent a real regression (axis-swap/winding, why polygon ends aren't bbox-centered, and the buildAngles corner-anchoring summary) and tighten those to a line or two, per CONTRIBUTING.md's "keep comments short and useful". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
hbehrensj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I built loftmorph as a standalone tool for lofting a
solid between two 2D cross-sections. Found SketchForge and wanted that as a real, parametric
primitive in the editor rather than an import-a-static-STL workaround — so this ports the
algorithm in as a new "Loft" shape next to Box/Cylinder/Gear.
Oval/Rectangle/Triangle/Pentagon/Hexagon on each end, independent size + rotation (top mirrors
how cone's Top Radius works independently of its base). Wired into every place "gear" touches.
Affects: storage (new
loft*fields in.skf), export (STL/OBJ/STEP via the existingboolean/export pipeline), and undo/redo (new fields added to the shape-equality check that backs
history dedup). No changes to grouping/import mechanics themselves.
Testing
npm run typecheck+ test suite (newloftGeometry.test.ts, including arotational-symmetry check that caught a real centering bug during development)
use as a boolean hole, export STL and re-import it, save a project and reload the page
Notes
slightly past its nominal bounding box, so the resize gizmo won't always hug the mesh exactly
in that combination. Cosmetic only — doesn't affect the generated geometry.