Skip to content

Use correct logger - #35

Merged
nichollsh merged 1 commit into
mainfrom
hn/logs
Jul 29, 2026
Merged

nichollsh merged 1 commit into
mainfrom
hn/logs

Conversation

@nichollsh

Copy link
Copy Markdown
Member

This pull request introduces a small update to correct the logging by updating logger names to include a package prefix. Closes #34

@egpbos egpbos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: simple and clean!

One question: did you test this? I think installing PROTEUS in this repo's CI just to test logging would be overkill, but at least trying it out once on some machine would be good. It's not a blocker for merging imho, since fwl-io is still in active development anyway, and logging is already broken, so merging won't degrade anything in any case.

@nichollsh

Copy link
Copy Markdown
Member Author

Yes! I did test it. Thank you for checking.

I tested it by deleting some of the files in the FWL_DATA folder (the mass radius ones) which forced a re-download This causes fwl-io to create some logging calls, which then appear with the correct formatter/style in the terminal and PROTEUS log file. Perhaps I should have screenshotted this for the PR description above.

I agree that, at some point soon, we should implement some robust testing into this repo which probes the interaction between fwl-io and other FWL modules.

Thanks for the review!

@nichollsh
nichollsh merged commit 8667827 into main Jul 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fwl-io configures its logger with an incorrect name

2 participants