Bump AGNI to restore the SOCRATES thermal source-function grid - #866
Merged
Merged
Conversation
AGNI c7ffdf00 coarsened the SOCRATES thermal-source-function table from a 3.25 K step to a 25 K step, which pushed the banded-OLR interpolation error in the transparent-limit test past its tolerance. Move to 8a494d7c, which restores a 5 K step; the transparent blackbody test now passes across the full T_surf sweep (1000-3000 K) within RTOL_SOCRATES. SOCRATES stays pinned at 43b86d4d. Its reported version 2603.9 still meets AGNI's new minimum-version check.
The AGNI badge in the module-version table still pointed at c7ffdf00 after the pin moved to 8a494d7c. Regenerate the table from pyproject.toml.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
=======================================
Coverage 93.45% 93.46%
=======================================
Files 113 113
Lines 16797 16797
Branches 2992 2992
=======================================
+ Hits 15698 15699 +1
+ Misses 1093 1092 -1
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This was a (partial?) duplicate of #863. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the AGNI pin from
c7ffdf00to8a494d7cto restore the SOCRATES thermal source-function tabulation grid.The nightly Integration tier fails on
test_transparent_banded_olr_recovers_blackbody_emission: the banded transparent OLR atT_surf = 1500 Kovershoots the black-body emission by about 0.073% (F_olr287271.57 vs 287062.70 W/m^2, toleranceRTOL_SOCRATES = 5e-4), on both ubuntu and macos with an identical value, so it is not a toolchain effect. It traces to AGNI commit66a61da0, which coarsened theprep_specthermal source-function grid from a roughly 3.25 K step to a 25 K step; the coarser tabulation raises the banded-RT interpolation error enough to tip this tolerance. AGNI restored a finer grid upstream (ba7bec1e, then8a494d7cat a 5 K step as a runtime-vs-accuracy compromise), so moving the pin forward to8a494d7crecovers the accuracy while keeping the hydrostatic-integration and spin parameters that the previous pin bump added. The SOCRATES pin is unchanged and still satisfies AGNI's minimum-version check.Validation of changes
Test configuration: Linux and macOS, Python 3.12, real SOCRATES spectral files.
Built AGNI at
8a494d7cand rantest_transparent_banded_olr_recovers_blackbody_emission: it passes over the full surface-temperature sweep (1000, 1500, 2000, 3000 K), all insideRTOL_SOCRATES. The full AGNI integration tier (-m 'integration and not slow') passes (44 of 44). The change topyproject.tomlis the single-line pin bump; the diff carries no other file. I confirmed by reverting only the thermal-grid constants in the previous pin that the test flips from failing to passing, which isolates the grid coarsening as the cause.Checklist