Skip to content

mushy_zone_factor warning says the setting has no effect while every run applies it #820

Description

@timlichtenberg

The config validator warns that mushy_zone_factor "has no effect" when the mantle EOS is not a PALEOS: table (src/proteus/config/_struct.py, the mzf < 1.0 and not mantle_eos.startswith('PALEOS:') branch). The setting is applied regardless: src/proteus/interior_struct/zalmoxis.py builds the derived solidus as T_sol(P) = T_liq(P) * mushy_zone_factor via _make_derived_solidus, and every run log reports the factor in use.

The warning should either be removed or narrowed to the case it is actually true for. As it stands it tells users the opposite of what the run does, and the run log is the authority.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingInterior/StructurePhysics - interior evolutionInterraIssue has been imported to the Interra Board projectPriority 2: highPriority level 2: high time criticality or importanceimport

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions