Repository navigation
Bug: Styles not applied. #1357
Description
Issue
From 10.2.1 to 10.2.2 we lost some of the styling on elements, both in slides and markdowns. Using https://github.com/FormidableLabs/spectacle/blob/main/examples/one-page/index.html as is with npx serve in root and navigating to that page we see the following where the headings should be pink but aren't.
Changing to previous version produces the correct results:
diff --git a/examples/one-page/index.html b/examples/one-page/index.html
index 37d6341..69c23bf 100644
--- a/examples/one-page/index.html
+++ b/examples/one-page/index.html
@@ -13,7 +13,7 @@
{
"imports": {
"htm": "https://esm.sh/htm@^3?external=react,react-dom",
- "spectacle": "https://esm.sh/spectacle@10?external=react,react-dom&bundle",
+ "spectacle": "https://esm.sh/spectacle@10.2.2?external=react,react-dom&bundle",
"broadcast-channel": "https://esm.sh/broadcast-channel@^4.17.0?external=react,react-dom",
"history": "https://esm.sh/history@^5.3.0?external=react,react-dom",
"kbar": "https://esm.sh/kbar@0.1.0-beta.40?external=react,react-dom",
Task
- Identify any other styling / theme issues.
- Diagnose and fix
Starting point
- Here's the diff of versions: spectacle@10.2.1...spectacle@10.2.2
- The change is this PR: fix: resolve React 19 compatibility by replacing defaultProps with attrs #1351
/cc @umxr
Activity