Skip to content

refactor: replace Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence#806

Open
Copilot wants to merge 6 commits intomasterfrom
copilot/refactor-sentence-handling
Open

refactor: replace Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence#806
Copilot wants to merge 6 commits intomasterfrom
copilot/refactor-sentence-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 3, 2026

Sentence ℒₒᵣ and Sentence ℒₛₑₜ were used directly throughout the codebase alongside the alias ArithmeticSentence, creating inconsistency. SetTheorySentence did not exist at all.

Changes

  • New alias: Added abbrev SetTheorySentence := Sentence ℒₛₑₜ in SetTheory/Basic/Misc.lean, parallel to the existing ArithmeticSentence := Sentence ℒₒᵣ and SetTheory := Theory ℒₛₑₜ
  • Arithmetic: Replaced all Sentence ℒₒᵣ occurrences with ArithmeticSentence across Incompleteness/, Bootstrapping/, Arithmetic/, and ProvabilityLogic/
  • Set theory: Replaced all Sentence ℒₛₑₜ occurrences with SetTheorySentence in SetTheory/Basic/Misc.lean and SetTheory/Basic/Axioms.lean

Sentence ℒₒᵣ⋆ in TA/Nonstandard.lean is intentionally untouched — it refers to the distinct extended language ℒₒᵣ⋆.

Original prompt

This section details on the original issue you should resolve

<issue_title>ℒₒᵣ / ℒₛₑₜ-Sentence to ArithmeticSentence / SetTheorySentence</issue_title>
<issue_description>混在していてよくないと思う.</issue_description>

Comments on the Issue (you are @copilot in this section)

@iehality たしかに.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ence`/`SetTheorySentence`

Co-authored-by: SnO2WMaN <15155608+SnO2WMaN@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor mixed sentence types into distinct categories refactor: replace Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence Mar 3, 2026
@SnO2WMaN
Copy link
Copy Markdown
Member

SnO2WMaN commented Mar 9, 2026

@copilot Summalize this

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot Summalize this

This PR standardizes how sentences are typed across the codebase:

  • New alias: SetTheorySentence := Sentence ℒₛₑₜ added to mirror the existing ArithmeticSentence := Sentence ℒₒᵣ
  • 17 files updated: All direct uses of Sentence ℒₒᵣArithmeticSentence and Sentence ℒₛₑₜSetTheorySentence

Files touched span Incompleteness/, Bootstrapping/, Arithmetic/, SetTheory/, and ProvabilityLogic/. The Sentence ℒₒᵣ⋆ in TA/Nonstandard.lean was left as-is since ℒₒᵣ⋆ is a distinct extended language.

@SnO2WMaN SnO2WMaN marked this pull request as ready for review March 9, 2026 02:14
@SnO2WMaN
Copy link
Copy Markdown
Member

SnO2WMaN commented Mar 9, 2026

大雑把にリファクタリングしたが #794 と競合している可能性はある.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ℒₒᵣ / ℒₛₑₜ-Sentence to ArithmeticSentence / SetTheorySentence

2 participants