refactor: replace Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence#806
Open
refactor: replace Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence#806
Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence#806Conversation
…ence`/`SetTheorySentence` Co-authored-by: SnO2WMaN <15155608+SnO2WMaN@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor mixed sentence types into distinct categories
refactor: replace Mar 3, 2026
Sentence ℒₒᵣ/Sentence ℒₛₑₜ with ArithmeticSentence/SetTheorySentence
Member
|
@copilot Summalize this |
Contributor
Author
This PR standardizes how sentences are typed across the codebase:
Files touched span |
Member
|
大雑把にリファクタリングしたが #794 と競合している可能性はある. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentence ℒₒᵣandSentence ℒₛₑₜwere used directly throughout the codebase alongside the aliasArithmeticSentence, creating inconsistency.SetTheorySentencedid not exist at all.Changes
abbrev SetTheorySentence := Sentence ℒₛₑₜinSetTheory/Basic/Misc.lean, parallel to the existingArithmeticSentence := Sentence ℒₒᵣandSetTheory := Theory ℒₛₑₜSentence ℒₒᵣoccurrences withArithmeticSentenceacrossIncompleteness/,Bootstrapping/,Arithmetic/, andProvabilityLogic/Sentence ℒₛₑₜoccurrences withSetTheorySentenceinSetTheory/Basic/Misc.leanandSetTheory/Basic/Axioms.leanSentence ℒₒᵣ⋆inTA/Nonstandard.leanis intentionally untouched — it refers to the distinct extended languageℒₒᵣ⋆.Original prompt
ℒₒᵣ/ℒₛₑₜ-Sentence toArithmeticSentence/SetTheorySentence#803💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.