Skip to content

Change Inhabited to Nonempty in ForcingRelation#796

Merged
SnO2WMaN merged 2 commits intomasterfrom
copilot/change-inhabited-to-nonempty
Feb 28, 2026
Merged

Change Inhabited to Nonempty in ForcingRelation#796
SnO2WMaN merged 2 commits intomasterfrom
copilot/change-inhabited-to-nonempty

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 28, 2026

The falsum lemmas in ForcingRelation.AllForces and WeakForcingRelation.AllForces used [Inhabited W] as their world non-emptiness constraint, while the rest of the Kripke semantics uniformly uses [Nonempty W].

Changes

  • ForcingRelation.AllForces.falsum: [Inhabited W][Nonempty W]
  • WeakForcingRelation.AllForces.falsum: [Inhabited ℙ][Nonempty ℙ]
  • Proof terms updated from h default to h (Classical.choice inferInstance) since Nonempty does not expose a default element
-- Before
@[simp] lemma falsum [BasicSemantics W] [Inhabited W] : ¬W ∀⊩ ⊥ := fun h ↦ by simpa using h default

-- After
@[simp] lemma falsum [BasicSemantics W] [Nonempty W] : ¬W ∀⊩ ⊥ := fun h ↦ by simpa using h (Classical.choice inferInstance)
Original prompt

This section details on the original issue you should resolve

<issue_title>Change Inhabited to Nonempty in ForcingRelation</issue_title>
<issue_description>> ForcingRelation.AllForces.falsum の仮定が Nonempty ではなく Inhabited なのは何かしら意図があるのだろうか?現状のKripke意味論のWorldの仮定はNonemptyにしているので微妙に合ってない(といっても1行ぐらいの差だが)

とくに意図はなかった.Nonempty に変えるべきだと思う.

Originally posted by @iehality in #790 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: SnO2WMaN <15155608+SnO2WMaN@users.noreply.github.com>
Copilot AI changed the title [WIP] Change Inhabited to Nonempty in ForcingRelation Change Inhabited to Nonempty in ForcingRelation Feb 28, 2026
@SnO2WMaN SnO2WMaN marked this pull request as ready for review February 28, 2026 12:09
@SnO2WMaN SnO2WMaN merged commit d0ade23 into master Feb 28, 2026
4 checks passed
@SnO2WMaN SnO2WMaN deleted the copilot/change-inhabited-to-nonempty branch February 28, 2026 12:10
tosiaki pushed a commit to tosiaki/Foundation-SetTheory that referenced this pull request Mar 1, 2026
…dFormalLogic#796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: SnO2WMaN <15155608+SnO2WMaN@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Inhabited to Nonempty in ForcingRelation

2 participants