Skip to content

Fix restore_format for non-contiguous original_dims #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-rl merged 1 commit into from
Jun 13, 2026
Merged

Fix restore_format for non-contiguous original_dims #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/magnify/postprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,12 @@ def restore_format(xp: xr.Dataset | xr.DataArray) -> xr.Dataset | xr.DataArray:
# If there are no original dimensions in this variable then don't do anything.
if len(original_dims) > 0:
var_dims = list(var.dims)
# We guarantee that original dimensions are contiguous so find their start and end.
# Find the indices of original dimensions in the current variable dimensions.
idxs = [i for i, x in enumerate(var_dims) if x in original_dims]
start, end = (idxs[0], idxs[-1] + 1)
# Keep all non-original dimensions in the same order while permuting the originals.
dim_order = var_dims[:start] + original_dims + var_dims[end:]
# Permute the original dimensions to match their order in __original_tile_dims__.
dim_order = list(var_dims)
for idx, dim in zip(idxs, original_dims, strict=True):
dim_order[idx] = dim
xp[name] = var.transpose(*dim_order)

del xp.attrs["__original_tile_dims__"]
Expand Down
Loading