refactor(errors): namespace provider error codes in gatewayErrorMap - #68
Open
MargaretKerubo wants to merge 2 commits into
Open
MargaretKerubo wants to merge 2 commits into
MargaretKerubo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the
gatewayErrorMapinto a nested map (map[string]map[string]string) to prevent collisions between different payment providers that might reuse the same raw error codes.It fulfills the requirements of Issue #63 by:
"mpesa"namespace."default"namespace for the generic error code examples.MapGatewayErrorCodefunction signature to accept aproviderargument, allowing it to search the provider-specific map before falling back to the"default"map.Type of change
Related issue
Closes #63
Details
gatewayErrorMaptype tomap[string]map[string]string.MapGatewayErrorCode(provider, code string) stringto check theprovidernamespace first, then fall back to"default".MapGatewayErrorCodein the provider packages that need updating (this lays the groundwork for mapping M-Pesa endpoint responses in Issue Map M-Pesa endpoint responses onto shared paykit.Response #59).Testing
mise run cilocally. Verified that the code compiles,golangci-lintpasses without warnings, and all existing tests pass (go test ./...).Checklist
go test ./...passes