feat(core): add missing fields to request structs - #67
Open
MargaretKerubo wants to merge 2 commits into
Open
MargaretKerubo wants to merge 2 commits into
MargaretKerubo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing data fields to the standard request structs in
requests.goto match the specifications defined in theplan.mdappendix.Prior to this change, the structs only contained the
IdempotencyKey. The new fields (likeAmount,TransactionID) provide the necessary data schema to map provider-specific payloads (such as M-Pesa's STK push) to the unifiedGatewayinterface.Type of change
Related issue
Closes #61
Details
PurchaseRequest&AuthorizeRequest: AddedAmount,Currency,Phone,Description,CallbackURL, andMetadatafields.CaptureRequest&RefundRequest: AddedTransactionIDandAmountfields to reference the original transaction and support partial capture/refunds.VoidRequest&StatusRequest: AddedTransactionIDfield.Testing
mise run cilocally. Verified that the code compiles,golangci-lintpasses without warnings, and all existing tests pass (go test ./...).Checklist
go test ./...passes