Skip to content

Create draft release with version bump - #55

Merged
tomusdrw merged 1 commit into
mainfrom
c/draft-release-on-version-bump
Jun 8, 2026
Merged

Create draft release with version bump#55
tomusdrw merged 1 commit into
mainfrom
c/draft-release-on-version-bump

Conversation

@tomusdrw

@tomusdrw tomusdrw commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

  • create the draft GitHub release when preparing the version bump
  • remove the merge-triggered draft release workflow
  • leave the release independent of a specific commit

Checks

  • actionlint .github/workflows/*.yml
  • git diff --check origin/main...HEAD

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR consolidates the release workflow by removing the draft-release.yml automation and updating release.yml messaging to reflect a simpler process where draft releases are pre-created, requiring only merge and publish steps in the main release workflow.

Changes

Release Workflow Consolidation

Layer / File(s) Summary
Release workflow messaging updates
.github/workflows/release.yml
PR body text updated to state that draft v<version> releases are already created. Write summary step instructions are rewritten to simplify merge-and-publish guidance, removing references to draft release creation during merge. Draft-release.yml workflow is removed entirely.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Create draft release with version bump' directly aligns with the main objectives of the PR, which are to create a draft release during version preparation and remove the merge-triggered workflow.
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the motivation for removing draft-release.yml and updating release.yml with details about draft release creation timing and workflow independence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch c/draft-release-on-version-bump

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Around line 74-81: The draft release step using softprops/action-gh-release@v2
currently creates tag v${{ steps.version.outputs.version }} against whatever
commit is checked out (main), which can be the pre-bump commit; fix by ensuring
the release action points at the bumped commit: set the action's
commit-ish/target to the commit/sha produced by the earlier bump/pr-head step
(the step that created the PR branch/head used in Lines 60-73) or to the
checkout step that contains the bumped files (e.g., reference that step's output
sha instead of the default), or alternatively move the Create draft GitHub
release step to a post-merge path so the tag is created after the bumped version
is merged (so .github/workflows/publish.yml will see matching
package.json.version).
- Line 75: The workflow currently references the mutable tag "uses:
softprops/action-gh-release@v2"; change this to a fixed commit SHA for
supply-chain safety by replacing that reference with "uses:
softprops/action-gh-release@<full-commit-sha>" where <full-commit-sha> is the
40-character commit hash from the softprops/action-gh-release repository (obtain
the SHA from the repo's GitHub commit history or the tag's commit), ensuring the
workflow points to an immutable commit instead of the mutable `@v2` tag.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3fb0f4ba-2424-4ae6-bbe1-5505d6105724

📥 Commits

Reviewing files that changed from the base of the PR and between a4a681e and 02dddec.

📒 Files selected for processing (2)
  • .github/workflows/draft-release.yml
  • .github/workflows/release.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/draft-release.yml

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
@tomusdrw
tomusdrw merged commit 4e90642 into main Jun 8, 2026
4 checks passed
@tomusdrw
tomusdrw deleted the c/draft-release-on-version-bump branch June 8, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant