Skip to content

Split snapshot and release package versions - #53

Merged
tomusdrw merged 2 commits into
mainfrom
c/release-exact-version
Jun 7, 2026
Merged

Split snapshot and release package versions#53
tomusdrw merged 2 commits into
mainfrom
c/release-exact-version

Conversation

@tomusdrw

@tomusdrw tomusdrw commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • publish every push to main as <version>-<short-sha>
  • publish GitHub Releases as the exact semantic version from the release tag
  • verify release tags match the checked-in package version
  • update the release workflow summary to show the exact release version

Examples:

  • main commit: 0.5.0-abc1234
  • GitHub Release v0.5.0: 0.5.0

Validation

  • actionlint .github/workflows/*.yml
  • git diff --check
  • executed the embedded snapshot rewrite against temporary manifests
  • verified push mode produces 0.4.0-abc123 and release mode remains 0.4.0

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Publishing workflows remove the automated short-SHA version-suffix feature: the publish.yml no longer computes short git SHA or runs inline Node script to rewrite package versions before publishing, while release.yml instructions are updated to reflect plain version numbers without the suffix.

Changes

Short-SHA version suffix removal

Layer / File(s) Summary
Remove version rewrite step from publish workflow
.github/workflows/publish.yml
The publish workflow step that computed a short git SHA and ran an inline update_versions.cjs script to rewrite dist/package.json and platform bandersnatch/npm/{darwin-arm64,linux-x64-gnu}/package.json versions (and corresponding optionalDependencies) is removed; the Publish platform packages step now directly follows the build step.
Update release instruction for version format
.github/workflows/release.yml
Release workflow step summary is updated to document publishing the draft release using ${{ steps.version.outputs.version }} without the -<short-sha> suffix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • FluffyLabs/typeberry-native#50: The retrieved PR's release/publish workflow logic around generating/publishing versioned artifacts with a -<short-sha> suffix is directly impacted by the main PR removing the short_sha output and associated version rewrite steps.
  • FluffyLabs/typeberry-native#32: Both PRs modify the .github/workflows/publish.yml workflow around the update_versions Node script before publishing—the retrieved PR fixes that step by switching from update_versions.js to update_versions.cjs, while the main PR removes it entirely.
  • FluffyLabs/typeberry-native#31: The main PR removes the version-rewrite logic from publish.yml, while the retrieved PR added that same kind of Node-based version update via update_versions.js, making the changes directly conflicting in the publish workflow's versioning step.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Split snapshot and release package versions' clearly summarizes the main change: distinguishing between snapshot versions (with SHA suffixes) and release versions (exact semantic versions).
Description check ✅ Passed The description is directly related to the changeset, explaining the strategy for versioning snapshots vs releases, providing concrete examples, and documenting validation steps performed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch c/release-exact-version

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw changed the title Publish exact release versions Split snapshot and release package versions Jun 7, 2026
@tomusdrw
tomusdrw merged commit f5d5210 into main Jun 7, 2026
4 checks passed
@tomusdrw
tomusdrw deleted the c/release-exact-version branch June 7, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant