Skip to content

build: configure lombok annotation processor path - #129

Merged
paodb merged 1 commit into
masterfrom
lombok-annotation-processor
Jul 27, 2026
Merged

build: configure lombok annotation processor path#129
paodb merged 1 commit into
masterfrom
lombok-annotation-processor

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 27, 2026

Copy link
Copy Markdown
Member

See https://github.com/FlowingCode/AddonsInternal/issues/202

Summary by CodeRabbit

  • Build Improvements
    • Centralized Lombok version management for more consistent builds.
    • Configured Lombok annotation processing to use the same managed version.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

Lombok build configuration

Layer / File(s) Summary
Centralize Lombok version and annotation processing
pom.xml
Defines lombok.version, reuses it for the Lombok dependency, and configures Lombok as a compiler annotation processor.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: flowingcodeci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: configuring Lombok’s annotation processor path in the build.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lombok-annotation-processor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pom.xml`:
- Around line 153-166: The maven-compiler-plugin configuration is currently only
in pluginManagement and is not applied during normal compilation. Add the same
plugin declaration under build/plugins, preserving its version and Lombok
annotationProcessorPaths configuration so the compiler uses it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01266ab0-5ed8-4316-8913-d49b3df75fa8

📥 Commits

Reviewing files that changed from the base of the PR and between 265b1d1 and 1019a9b.

📒 Files selected for processing (1)
  • pom.xml

Comment thread pom.xml
@javier-godoy
javier-godoy requested a review from paodb July 27, 2026 19:56
@javier-godoy
javier-godoy marked this pull request as ready for review July 27, 2026 19:56
@paodb
paodb merged commit 911dc9b into master Jul 27, 2026
5 checks passed
@paodb
paodb deleted the lombok-annotation-processor branch July 27, 2026 21:00
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants