Separate the fork question for the job that reads the ruleset (#62) - #145
Merged
iderex merged 1 commit intoAug 17, 2026
Merged
Conversation
The arrival walk in docs/quality-parity.md read the triggers, the branch and type filters and the job conditions. All three are about whether a job starts. One name in the candidate set can start and still fail, because half of what it compares is the ruleset on the platform rather than a file in the checkout, and nothing in the document said so. A reader taking the fork clause from it found two upload-derived names there and not this one. The section now names contexts.yml as the only workflow whose own run block asks the platform anything, quotes the step that stops the job when the fetch fails rather than letting it compare against an empty list, and separates the two things a run from a fork brings. The read-only token is measured: on the head of the Dependabot pull request #135 the job reported success and the fetch printed the count it read. The other thing, a token issued against a different repository, is not measured, and the text says so rather than reasoning from the first result to the second. The means is prose in the document the issue names as the place its results go, which carries commands and their output the way the rest of that file does and needs no apparatus to be maintained beside it. Nothing here closes the issue. No pull request from a fork has been opened on this board, and the first clause of the done-condition compares against a required set that is empty today. Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #62
What this changes
The walk of which contexts arrive gains one subsection. Everything that walk
read before is about whether a job starts: path filters, branch and type
filters, and job-level conditions.
required contextscan start and still beunable to finish, because half of what it compares is the ruleset on the
platform rather than a file in the checkout, and it is the only name in the
candidate set with that shape.
The subsection names the workflow, quotes the step that stops the job when the
fetch fails rather than letting it compare against an empty list, and splits
the fork question into the part that is measured and the part that is not.
Nothing else in the document moves and no other file is touched.
What failure it prevents
A required set assembled with
required contextsin it, on a board whosedocument beside the set has walked the fork question for two upload-derived
names and not for the one name that reads the gate itself. If that fetch cannot
be made from a fork, requiring the context closes the board to anybody who
cannot push a branch to it, which is the second of the three cases the issue is
written against, and the document a reader consults would not have raised it.
What was run
I ran the four commands
CONTRIBUTING.mdnames, at the commit being pushed,and the checker over this tree.
Every command the subsection quotes was run before it was written and its
output pasted from that run rather than retyped. The two tracker commands were
run against
Flowfin/laband the two git commands againstorigin/mainatdf980aa.What this does not do
It does not walk a fork. No pull request from a fork has been opened on this
board and nothing here opens one, so the second half of the token question is
unmeasured and the text says so in the place a reader would otherwise take the
first half as an answer to both.
It settles no name into the required set. That set is empty, which is the same
bound every other sentence in that section carries.
The measurement it does make is of a Dependabot pull request rather than of a
fork. Those two share a read-only token and are otherwise different routes, and
the subsection uses it for the token alone.
The means is prose in the document the issue names as where its results go. It
carries commands and their output the way the rest of that file does, and it
needs no apparatus maintained beside it.
There is no second reader for this change tonight. What stands in place of one
is the output above and the commands in the subsection, each of which
reproduces against
origin/main.