Say which contexts arrive on which pull requests - #139
Merged
iderex merged 1 commit intoAug 16, 2026
Conversation
The parity document named the target's context strings and left two of them ambiguous here. `CodeQL` and `Audit workflows (zizmor)` are each two strings on this board: a job reports one and a code-scanning upload reports the other, and only one of the two arrives on a pull request whose token is read-only. A required set assembled from the rows as they stood could have taken the upload's name, which would hold open every pull request the upload condition excludes while nothing on the pull request said why. The same section carries the other half of the arrival question. The command this document hands issue #26 to assemble the set from reads a commit on the default branch, and three workflows here have no push trigger, so that command omits three contexts every pull request reports and offers one that no pull request can report. Both directions are measured and quoted. Measured rather than reasoned about: the upload step is skipped on a pull request the condition excludes, the step that fails on findings runs anyway, and the upload-derived name is absent from that commit's check runs while the job's name is present. The fork route is still unwalked and the section says so. No pull request from a fork has been opened here, and `CodeQL` arrived on the read-only-token pull request measured, so nothing here says what a fork produces for it. Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nothing. It moves #62, and the two clauses that issue is still open on
are named at the bottom.
What this changes
docs/quality-parity.mdgains a section next to the required set saying whichcontexts arrive, on which pull requests, and which of this board's strings each
of two table rows is about. The two rows for
CodeQLandAudit workflows (zizmor)gain one sentence each pointing at it.Two facts drive it, both measured rather than reasoned about.
A code-scanning upload creates a check run of its own, so
CodeQLandzizmorare names beside the job names
CodeQL (go)andAudit workflows (zizmor). Theupload in
.github/workflows/zizmor.ymlis conditional and the step that failson findings is not, so on a pull request running with a read-only token the job
arrives and reports while the upload-derived context never appears. That is
measured on a pull request open on this board today rather than read off the
condition. It decides one name:
zizmorcannot go into the required set,because requiring it would hold open every pull request the condition excludes
with nothing on the pull request saying why.
The command this document hands #26 to assemble the required set from resolves
origin/main, and a commit on the default branch is reached by a push. Threeworkflows here carry no push trigger, so that command omits three contexts every
pull request reports and offers one that no pull request can report. Both
directions of the difference are quoted from
commover the two sets.The means
Prose in the document the issue names as the place to write the result, because
the artefact is a reading of a live setting rather than a guard. Nothing here is
a rule a machine could refuse: every claim is instead quoted with the command
that produced it, and the section says at the end what it did not settle.
Evidence
Run at
c9780aa, from this checkout:The timing lines the suite and the runner also print are cut, and nothing else
is.
Every command quoted inside the new section was run against
origin/mainoragainst the platform before it was written down, and each one is written so a
reader can re-run it.
What this does not settle
The fork route is unwalked. No pull request from a fork has been opened here,
and the condition measured has two arms of which only the second was reached, so
nothing in this change says what a fork produces.
CodeQLdid arrive on theread-only-token pull request measured, so it gains no verdict here either.
The required set is empty, so nothing in this change reports a required context
that failed to arrive. It is about which names a set could hold.
#62 therefore stays open on its first clause, which needs the set #26 assembles,
and on the fork half of its second.
No second person has read this change. The evidence above stands in place of
one.