Name the exact version in a pin comment rather than the major - #138
Merged
iderex merged 1 commit intoAug 16, 2026
Merged
Conversation
The workflow audit was red on every pull request opened against this board and no change in the tree or in flight repaired it. Two steps in codeql.yml pinned a commit and commented it `# v4`, and a major version is a reference upstream moves. The tag moved on 2026-08-13, so the comment stopped being true without anybody here touching a file, and zizmor reported ref-version-mismatch at both sites at medium severity. The pinned commit does not change. `5595ccaf912efad79be6eef63a5619ff05969be3` is the commit tag `v4.37.6` points at, and the comment now says so, so no version arrives that has not already walked this board's gate. The failure it prevents is a check that is red on everything and blocks nothing. That is a column people learn to scroll past, and the next finding it reports arrives where nobody is reading. The audit is outside the required set, so a permanent red here refuses no merge and only costs attention. Every other pin in this tree already named an exact version, so this is the two outliers joining the thirty-three rather than a new convention. The spelling is written at both files a reader of those steps opens: the reason for it at the sites in codeql.yml, and the rule in the block in zizmor.yml that says what a future workflow change must keep. That block also listed a pin-comment mismatch among the pedantic hygiene findings this gate deliberately does not act on, and that was wrong. The regular persona reports it, the gate step fails the build on it, and it did. The sentence is corrected where it stood. Refs #137 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
What this changes
Two steps in
.github/workflows/codeql.ymlpinned a commit and commented it# v4. The comment now names# v4.37.6, which is the exact version the pinnedcommit is tagged as. The commit itself is unchanged, so nothing new is run:
That is the first of the three ways out the issue lists, and it is the one that
takes no version this board's gate has not already walked.
v4today pointssomewhere else, and that somewhere else is a release published after the last
green run on the default branch:
The spelling this repository uses is written at the two places a reader of those
steps opens. The header of
codeql.ymlsays why the comment names an exactversion and hands over the command that finds a bare major anywhere in the tree.
The rule block in
zizmor.yml, which is where a future workflow change is toldwhat to keep, now names the spelling next to the other four things it already
names.
That block also listed a pin-comment mismatch among the low-severity hygiene
findings the pedantic persona adds and this gate deliberately does not act on.
That was wrong. It is corrected where it stood, and it rides in this change
rather than a separate one because the sentence sits four lines above the rule
this change edits.
What failure it prevents
A check that is red on everything and blocks nothing. The audit is outside the
required set on this board:
So the permanent red refused no merge, and what it cost instead was a column
people stop reading. The next finding the audit reports would have arrived
there.
The narrower failure is the comment itself. A comment naming a moving reference
is a claim that goes stale on somebody else's schedule, with no change here,
which is what happened. Every zizmor run this board recorded before the tag
moved concluded success, and both runs recorded after it concluded failure:
An exact version is a claim about the commit written beside it, and that cannot
move.
Every other pin in this tree already named an exact version, so this is two
outliers joining the rest rather than a convention being introduced. Counted on
the parent of this change:
What was run
The audit that reports this runs on GitHub and not on this machine, so the
before and after are two runs of the same job rather than a local reproduction.
Before, on the head of #136, which touches no workflow file:
That red is what shows the audit bites for the reason it names, and it bit at
those two sites and at no other, on a change that contained neither of them.
After, on this head, the same job over the same fourteen files:
The suppressed pair is unchanged across both runs, so what moved is the two
medium findings and nothing else. Every other check on this head is green:
Locally, at the head of this branch:
zizmor was not run on this machine.
uvx,uvandzizmorare all absenthere, and the gate installs it from a wheel at run time, so the verdict that
counts is the job's.
Nobody but me has read this change. There is no second reader on this board
tonight, and the evidence above stands in place of one rather than alongside
one.
What this does not do
It does not move a pin.
github/codeql-actionruns at the same commit afterthis change as before it, so nothing here is a statement about
v4.37.7, andwhether to take that is the update tool's to raise.
It does not add a check. What refuses a wrong pin comment is the audit, which
already did, and this change makes it stop refusing rather than giving it a
second reader in this tree. Nothing in this tree reads a pin comment.
It does not put the audit in the required set. That stays where issue #26 holds
it, and the issue says why a board-wide red becoming a board-wide block would
not have been a repair.
It does not silence anything. There is no suppression and no ignore comment,
and the audit still reports these two sites if the comment and the commit ever
disagree again.