fix: include-identity-traits-in-cache-key#262
Merged
Conversation
Zaimwa9
requested review from
khvn26 and
talissoncosta
and removed request for
a team and
khvn26
talissoncosta
approved these changes
Apr 17, 2026
Contributor
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
Looks good to me! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #238
Chose option 2 (include traits in cache key) from the proposed solutions as 1 (new boolean sdk option) is just covering the bug while adding complexity
generateIdentityCacheKeythat hash sorted and normalized traits in the cache key (sameflags-{identifier}key if no traits)How did you test this code?