-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: correct archive path in onboarding template #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The onboarding template incorrectly documented the archive path as `openspec/archive/YYYY-MM-DD--<name>/` when the actual implementation uses `openspec/changes/archive/YYYY-MM-DD-<name>/`. This fixes two issues: - Missing `changes/` directory in the path - Double dash `--` instead of single dash `-` Fixes discussion #583
📝 WalkthroughWalkthroughArchive paths in skill templates are updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Greptile OverviewGreptile SummaryFixed two documentation errors in the onboarding template that would have misled AI agents and users about the archive behavior. Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant OnboardingSkill
participant ArchiveCommand
participant FileSystem
User->>OnboardingSkill: Run /opsx:onboard
OnboardingSkill->>OnboardingSkill: Display Phase 10: Archive
OnboardingSkill->>User: Show documentation:<br/>"Archives go to openspec/changes/archive/YYYY-MM-DD-<name>/"
User->>OnboardingSkill: Execute openspec archive "<name>"
OnboardingSkill->>ArchiveCommand: archive(changeName)
ArchiveCommand->>ArchiveCommand: getArchiveDate() → YYYY-MM-DD
ArchiveCommand->>ArchiveCommand: Create archiveName: YYYY-MM-DD-<name>
ArchiveCommand->>FileSystem: Move openspec/changes/<name>
FileSystem->>FileSystem: → openspec/changes/archive/YYYY-MM-DD-<name>
ArchiveCommand->>User: Display "Archived to: openspec/changes/archive/YYYY-MM-DD-<name>/"
Note over OnboardingSkill,ArchiveCommand: Documentation now matches actual behavior
|
Summary
openspec/archive/→openspec/changes/archive/)YYYY-MM-DD--→YYYY-MM-DD-)Context
Reported in discussion #583 - a user noticed archives appearing in
openspec/archive/instead ofopenspec/changes/archive/. Investigation found the onboarding template was documenting the wrong path, which could cause agents following the onboarding to create archives in the wrong location.Test plan
openspec/changes/archive/YYYY-MM-DD-<name>//opsx:onboardand confirm archive step shows correct path🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.