remove random movement test - #129
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes a simulator-driven motion-planning test that previously exercised random multi-robot movement and collision avoidance behavior.
Changes:
- Deleted
random_movement_test.py, which ran a multi-robot random-target navigation scenario and asserted no collisions plus target completion.
Comments suppressed due to low confidence (1)
utama_core/tests/motion_planning/random_movement_test.py:1
- This PR deletes the only test that exercises
RandomMovementStrategy(and its collision-avoidance behavior under repeated random target selection). After this change, the strategy remains in the codebase (e.g.utama_core/strategy/examples/motion_planning/random_movement_strategy.pyandmain.py) but has no test coverage, so regressions in random-target generation / callback invocation / multi-robot separation won’t be caught by CI.
If this test was removed due to flakiness or runtime, consider keeping it but marking it as an integration/slow test (so it’s opt-in), or replacing it with a smaller deterministic unit test for the strategy’s target selection + on_target_reached callback behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.