fix(x11): desktop-skin --plate og parse - #28
Open
FineComputer14451 wants to merge 2 commits into
Open
Conversation
Bare --plate/--dpi/--panel-size no longer die in the first parse pass before the next-arg pass runs; reject another flag as the value.
Space-form parse check sets DISPLAY=:0 for the dry-run child so CI (no X session) still exercises --plate og without require_session dying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--plate og/--dpi 120space-form (first pass was dying on bare--platebefore the value pass).--plate --dry-runstyle mistakes.self-testto exercise space-form parse.Phone smoke hit this on main after pull.
Test plan
bash scripts/desktop-skin.sh self-testapply --plate og --dpi 120 --dry-runapply --plate=og --dpi=120 --panel-slim